Refactor timeout #179
Closed
Refactor timeout #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahamath-unnisa
force-pushed
the
refactor-timeout
branch
from
667496a to
0c5ae27
Compare
Author
|
Hi !I’ve re-signed all commits.The CI is pending maintainer approval — please let me know if any further changes are needed. |
ValuedMammal
added a commit
that referenced
this pull request
Nov 11, 2025
…Duration>` 5dc4bb6 ci: bump clippy to 1.90.0 (valued mammal) e31cf47 feat!: Change ConfigBuilder::timeout to accept Option<Duration> (valued mammal) Pull request description: Change `ConfigBuilder::timeout` to accept `Option<Duration>`. This makes the API more explicit and less error prone, as the caller no longer needs to assume the units of the given duration. Also updated the code to run clippy check in CI using rust 1.90.0. BREAKING: The `timeout` method on `ConfigBuilder` is changed to accept a `timeout: Option<Duration>`. Previously it was `Option<u8>`. fix #151 fix #175 Supersedes #179 ACKs for top commit: oleonardolima: ACK 5dc4bb6 Tree-SHA512: cd6ca6fdd91dcf6f193327ca40f6d37ea8b1b548102f080d0b72a0df509f6455aa50ee43148e4746ca6b295a30a78cb7d786fb0e90c050448e96e122a5b8c92d
Contributor
|
@Rahamath-unnisa Thanks for looking into it. This is now completed in #180. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
This PR updates the ElectrumClientBuilder (and related builder logic) to use std::time::Duration for timeout configuration, instead of a u8 value representing seconds.
Notes to the reviewers
Replaced timeout: Option with timeout: Option in the builder.
Adjusted all relevant function calls and tests accordingly.
Confirmed that all existing integration tests pass.
Checklists:
I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt, cargo clippy, and cargo test before pushing
I’m linking the issue being fixed by this PR
Supersedes #178
This replaces the previous PR which had CI and branch issues.